Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add ie to storage.GetState and GetMetadata #91409

Closed

Conversation

ZhouXing19
Copy link
Collaborator

@ZhouXing19 ZhouXing19 commented Nov 7, 2022

WIP

Informs: #91004

Release Note: None

…ager to eval

This commit:

1. moves the definition of StreamIngestionManager and ReplicationStreamManager
to eval;
2. has planner implements functions in StreamIngestionManager and
ReplicationStreamManager, so that they won't take eval.Context and evalCtx.Txn
as parameters.

Release note: None
This commit is part of the effort of having an internal executor better bound
to its outer txn if there's one.

The next step after this commit is to replace the executor used in
`s.ptsProvider.GetState()` in `SQLTranslator.Translate()` to the one hanging
off `SQLTranslator`.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ZhouXing19
Copy link
Collaborator Author

switching to #91404 and closing this one

@ZhouXing19 ZhouXing19 closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants